Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/debug/internal/gocore: TestLT and TestMappings failing on openbsd-amd64 builders #43927

Closed
bcmills opened this issue Jan 26, 2021 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-OpenBSD
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 26, 2021

2020-12-08T15:29:29-c934e1b/openbsd-amd64-64
2020-12-08T15:29:29-c934e1b/openbsd-amd64-68

--- FAIL: TestMappings (0.01s)
    --- FAIL: TestMappings/useExePath=false (0.01s)
        core_test.go:57: opcode=0xf8, want 0x31
        core_test.go:69: class_to_size[1]=0, want 8
    --- FAIL: TestMappings/useExePath=true (0.00s)
        core_test.go:57: opcode=0xf8, want 0x31
        core_test.go:69: class_to_size[1]=0, want 8
FAIL
FAIL	golang.org/x/debug/internal/core	0.093s
--- FAIL: TestLT (0.07s)
panic: runtime error: makeslice: len out of range [recovered]
	panic: runtime error: makeslice: len out of range

goroutine 6 [running]:
testing.tRunner.func1.2(0x585220, 0x5ea300)
	/tmp/workdir/go/src/testing/testing.go:1144 +0x332
testing.tRunner.func1(0xc000001380)
	/tmp/workdir/go/src/testing/testing.go:1147 +0x4b6
panic(0x585220, 0x5ea300)
	/tmp/workdir/go/src/runtime/panic.go:965 +0x1b9
golang.org/x/debug/internal/gocore.region.String(0xc000088160, 0x4aaa70, 0xc0002f76d0, 0xc, 0xc00046ce50)
	/tmp/workdir/gopath/src/golang.org/x/debug/internal/gocore/region.go:121 +0x96
golang.org/x/debug/internal/gocore.Core(0xc0000b0000, 0xd, 0x5b72e1, 0x8)
	/tmp/workdir/gopath/src/golang.org/x/debug/internal/gocore/process.go:155 +0x299
golang.org/x/debug/internal/gocore.loadExample(0xc000001380, 0x0)
	/tmp/workdir/gopath/src/golang.org/x/debug/internal/gocore/gocore_test.go:40 +0xeb
golang.org/x/debug/internal/gocore.TestLT(0xc000001380)
	/tmp/workdir/gopath/src/golang.org/x/debug/internal/gocore/dominator_test.go:16 +0x45
testing.tRunner(0xc000001380, 0x5c2968)
	/tmp/workdir/go/src/testing/testing.go:1194 +0xef
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1239 +0x2b3
FAIL	golang.org/x/debug/internal/gocore	0.162s

Given the timing, I'm inclined to suspect CL 270380 in the main Go repo (CC @4a6f656c, @randall77, @ianlancetaylor, @cherrymui).

@bcmills bcmills added OS-OpenBSD NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 26, 2021
@bcmills bcmills added this to the Backlog milestone Jan 26, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Jan 26, 2021

I think this is a release-blocker for Go 1.16 via #11811 (CC @golang/release).

@bcmills bcmills modified the milestones: Backlog, Go1.16 Jan 26, 2021
@toothrot
Copy link
Contributor

We may end up not considering it a release-blocker, as openbsd-amd64 is not a First-Class Port.

@4a6f656c
Copy link
Contributor

I've confirmed that this is due to CL 270380 - I'll have a closer look.

@gopherbot
Copy link

Change https://golang.org/cl/287252 mentions this issue: syscall: remove pad from known openbsd syscalls

@golang golang locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-OpenBSD
Projects
None yet
Development

No branches or pull requests

5 participants
@toothrot @bcmills @4a6f656c @gopherbot and others