Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: mismatch between GetLatestMajorPathForV1Path and getLatestMajorVersion #43849

Closed
julieqiu opened this issue Jan 22, 2021 · 2 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite

Comments

@julieqiu
Copy link
Member

julieqiu commented Jan 22, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/mediocregopher/radix

Screenshot

image

What did you do?

Visited https://pkg.go.dev/github.com/mediocregopher/radix and was redirected to https://pkg.go.dev/github.com/mediocregopher/radix/v4. This should redirect to https://pkg.go.dev/github.com/mediocregopher/radix/v3, since that is the highest tagged version.

This is due to a mismatch in the logic between GetLatestMajorPathForV1Path and getLatestMajorVersion. GetLatestMajorPathForV1Path looks for the highest major version, numerically. getLatestMajorVersion takes into account whether the module has tagged versions.

@gopherbot gopherbot added this to the Unreleased milestone Jan 22, 2021
@julieqiu julieqiu added pkgsite NeedsFix The path to resolution is known, but the work has not been done. help wanted and removed pkgsite labels Jan 22, 2021
@kirandasika0
Copy link

@julieqiu I would like to pick up this issue

@julieqiu
Copy link
Member Author

This has been fixed.

@golang golang locked and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Development

No branches or pull requests

3 participants