Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestReadTimeoutFluctuation failures with "unexpected type" #43844

Closed
bcmills opened this issue Jan 22, 2021 · 2 comments
Closed

net: TestReadTimeoutFluctuation failures with "unexpected type" #43844

bcmills opened this issue Jan 22, 2021 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 22, 2021

2021-01-22T06:35:01-ec1b945/netbsd-arm64-bsiegert

--- FAIL: TestReadTimeoutFluctuation (0.03s)
    timeout_test.go:686: unexpected type on 1st nested level: *errors.errorString
    timeout_test.go:689: Read took 28.612908ms; expected 100ms
FAIL
FAIL	net	30.866s

2019-11-12T22:09:05-a56d755/windows-amd64-longtest

--- FAIL: TestReadTimeoutFluctuation (0.25s)
    timeout_test.go:686: unexpected type on 1st nested level: *errors.errorString
    timeout_test.go:689: Read took 250.9847ms; expected 100ms
FAIL
FAIL	net	63.307s

This test would benefit from a more useful test failure output for this failure mode to make it clearer to diagnose.

CC @bradfitz @ianlancetaylor

@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 22, 2021
@bcmills bcmills added this to the Backlog milestone Jan 22, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Jan 22, 2021

See also #36108.

@bcmills
Copy link
Contributor Author

bcmills commented Aug 30, 2023

There have been a lot of net/http fixes since this issue was filed, and watchflakes will file a new issue should it recur. Closing as obsolete.

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

1 participant