Skip to content

cmd/compile: replace ir.Name map with ir.NameSet #43819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oiooj opened this issue Jan 21, 2021 · 5 comments
Closed

cmd/compile: replace ir.Name map with ir.NameSet #43819

oiooj opened this issue Jan 21, 2021 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.17

Comments

@oiooj
Copy link
Member

oiooj commented Jan 21, 2021

As CL 282212 mentioned, we should clean all map[*ir.Name]bool with ir.NameSet.

I'm working on this clean.

/cc @mdempsky
@oiooj oiooj added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 21, 2021
@oiooj oiooj self-assigned this Jan 21, 2021
@oiooj oiooj added this to the Go1.17 milestone Jan 21, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/284897 mentions this issue: [dev.regabi] cmd/compile: replace ir.Name map with ir.NameSet in inlining

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/284898 mentions this issue: [dev.regabi] cmd/compile: replace ir.Name map with ir.NameSet for SSA

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/284899 mentions this issue: [dev.regabi] cmd/compile: replace ir.Name map with ir.NameSet for dwarf

gopherbot pushed a commit that referenced this issue Jan 21, 2021
@oiooj
[dev.regabi] cmd/compile: replace ir.Name map with ir.NameSet for SSA

Verified

This commit was signed with the committer’s verified signature.
mcculls Stuart McCulloch
GPG key ID: 29641ACA805A0ABB
Verified
Learn about vigilant mode
5248f59 
Same as CL 284897, but for SSA.

Passes toolstash -cmp.

Updates #43819

Change-Id: I3c500ad635a3192d95d16fdc36f154ba3ea5df69
Reviewed-on: https://go-review.googlesource.com/c/go/+/284898
Run-TryBot: Baokun Lee <bk@golangcn.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Baokun Lee <bk@golangcn.org>
gopherbot pushed a commit that referenced this issue Jan 21, 2021
@oiooj
[dev.regabi] cmd/compile: replace ir.Name map with ir.NameSet in inli…

Verified

This commit was signed with the committer’s verified signature.
mcculls Stuart McCulloch
GPG key ID: 29641ACA805A0ABB
Verified
Learn about vigilant mode
970d8b6 
…ning

As CL 282212 mentioned, we should clean all map[*ir.Name]bool with
ir.NameSet.

Passes toolstash -cmp.

Updates #43819

Change-Id: I1ce5d2055f88539f807dc021cd8e3941b425bc4e
Reviewed-on: https://go-review.googlesource.com/c/go/+/284897
Run-TryBot: Baokun Lee <bk@golangcn.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Baokun Lee <bk@golangcn.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
gopherbot pushed a commit that referenced this issue Jan 21, 2021
@oiooj
[dev.regabi] cmd/compile: replace ir.Name map with ir.NameSet for dwarf

Verified

This commit was signed with the committer’s verified signature.
mcculls Stuart McCulloch
GPG key ID: 29641ACA805A0ABB
Verified
Learn about vigilant mode
d7e71c0 
Same as CL 284897, but for dwarf.

Passes toolstash -cmp.

Fixes #43819

Change-Id: Icbe43aa2e3cb96e6a6c318523c643247da8e4c74
Reviewed-on: https://go-review.googlesource.com/c/go/+/284899
Run-TryBot: Baokun Lee <bk@golangcn.org>
Trust: Baokun Lee <bk@golangcn.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/285913 mentions this issue: [dev.regabi] cmd/compile: replace ir.Name map with ir.NameSet for SSA 2

gopherbot pushed a commit that referenced this issue Jan 23, 2021
@oiooj
[dev.regabi] cmd/compile: replace ir.Name map with ir.NameSet for SSA 2
d05d6fa 
Same as CL 284897, the last one.

Passes toolstash -cmp.

Updates #43819

Change-Id: I0bd8958b3717fb58a5a6576f1819a85f33b76e2d
Reviewed-on: https://go-review.googlesource.com/c/go/+/285913
Run-TryBot: Baokun Lee <bk@golangcn.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Trust: Baokun Lee <bk@golangcn.org>
@mdempsky
Copy link
Contributor

This is fixed on dev.regabi. Thanks @oiooj!

@golang golang locked and limited conversation to collaborators Jan 25, 2022
@rsc rsc unassigned oiooj Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
3 participants
@mdempsky @oiooj @gopherbot