Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestScript/mod_get_fallback relies on x/tools not being tagged [1.14 backport] #43796

Closed
gopherbot opened this issue Jan 20, 2021 · 3 comments
Closed

cmd/go: TestScript/mod_get_fallback relies on x/tools not being tagged [1.14 backport] #43796

gopherbot opened this issue Jan 20, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.14.15

Comments

@gopherbot
Copy link

@rolandshoemaker requested issue #43795 to be considered for backport to the next 1.14 minor release.

This is also an issue on 1.14 and 1.15. On 1.15 TestScript/get_update_unknown_protocol is also broken.
@gopherbot please open backport issues.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 20, 2021
@gopherbot gopherbot mentioned this issue Jan 20, 2021
Closed
@gopherbot gopherbot added this to the Go1.14.15 milestone Jan 20, 2021
@dmitshur
Copy link
Contributor

Approving, this is a test fix that is necessary after a security fix.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure. and removed CherryPickCandidate Used during the release process for point releases labels Jan 20, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/284798 mentions this issue: [release-branch.go1.14] cmd/go: fix mod_get_fallback test

@gopherbot
Copy link
Author

Closed by merging 123e378 to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Jan 20, 2021
@dmitshur
[release-branch.go1.14] cmd/go: fix mod_get_fallback test
123e378 
Fixes #43796

Change-Id: I3d791d0ac9ce0b523c78c649aaf5e339a7f63b76
Reviewed-on: https://go-review.googlesource.com/c/go/+/284797
Trust: Jay Conrod <jayconrod@google.com>
Run-TryBot: Jay Conrod <jayconrod@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
(cherry picked from commit be28e5a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/284798
@golang golang locked and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.14.15
Development

No branches or pull requests
3 participants
@dmitshur @rolandshoemaker @gopherbot