Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestScript/mod_get_fallback relies on x/tools not being tagged #43795

Closed
rolandshoemaker opened this issue Jan 20, 2021 · 4 comments
Closed

cmd/go: TestScript/mod_get_fallback relies on x/tools not being tagged #43795

rolandshoemaker opened this issue Jan 20, 2021 · 4 comments
Labels
FrozenDueToAge GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.16

Comments

@rolandshoemaker
Copy link
Member

The script assumes the go get log will say golang.org/x/tools/@latest rather than golang.org/x/tools/@v/v0.1.0.
@rolandshoemaker rolandshoemaker added this to the Go1.16 milestone Jan 20, 2021
@rolandshoemaker
Copy link
Member Author

This is also an issue on 1.14 and 1.15. On 1.15 TestScript/get_update_unknown_protocol is also broken.
@gopherbot please open backport issues.

This was referenced Jan 20, 2021
Closed
Closed
@gopherbot
Copy link

Backport issue(s) opened: #43796 (for 1.14), #43797 (for 1.15).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@dmitshur dmitshur added GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure. labels Jan 20, 2021
@dmitshur
Copy link
Contributor

CC @jayconrod, @matloob, @bcmills via owners.

@jayconrod jayconrod self-assigned this Jan 20, 2021
@gopherbot
Copy link

Change https://golang.org/cl/284797 mentions this issue: cmd/go: fix mod_get_fallback test

@mdempsky mdempsky mentioned this issue Jan 23, 2021
Closed
@golang golang locked and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
4 participants
@jayconrod @dmitshur @rolandshoemaker @gopherbot