Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/execabs: disable tests on js-wasm [1.14 backport] #43792

Closed
gopherbot opened this issue Jan 20, 2021 · 3 comments
Closed

internal/execabs: disable tests on js-wasm [1.14 backport] #43792

gopherbot opened this issue Jan 20, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.14.15

Comments

@gopherbot
Copy link

@rolandshoemaker requested issue #43791 to be considered for backport to the next 1.14 minor release.

This is also a problem on 1.14 and 1.15.
@gopherbot please open backport issues.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 20, 2021
@gopherbot gopherbot mentioned this issue Jan 20, 2021
Closed
@gopherbot gopherbot added this to the Go1.14.15 milestone Jan 20, 2021
@dmitshur
Copy link
Contributor

Approving, this is a test fix that is necessary after a security fix.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure. and removed CherryPickCandidate Used during the release process for point releases labels Jan 20, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/285055 mentions this issue: [release-branch.go1.14] internal/execabs: only run tests on platforms that support them

@gopherbot
Copy link
Author

Closed by merging b57ea3d to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Jan 21, 2021
@rolandshoemaker @dmitshur
[release-branch.go1.14] internal/execabs: only run tests on platforms…
b57ea3d 
… that support them

Fixes #43792

Change-Id: I3bf022a28b194f0089ea96d93e56bbd9fb7e0aa8
Reviewed-on: https://go-review.googlesource.com/c/go/+/285055
Trust: Roland Shoemaker <roland@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.14.15
Development

No branches or pull requests
3 participants
@dmitshur @rolandshoemaker @gopherbot