Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/execabs: disable tests on js-wasm #43791

Closed
rolandshoemaker opened this issue Jan 20, 2021 · 7 comments
Closed

internal/execabs: disable tests on js-wasm #43791

rolandshoemaker opened this issue Jan 20, 2021 · 7 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@rolandshoemaker
Copy link
Member

os/exec.{LookPath,Command} is disabled on js-wasm so internal/execabs won't work on the platform.

@rolandshoemaker rolandshoemaker added this to the Go1.16 milestone Jan 20, 2021
@rolandshoemaker
Copy link
Member Author

This is also a problem on 1.14 and 1.15.
@gopherbot please open backport issues.

@gopherbot
Copy link

Backport issue(s) opened: #43792 (for 1.14), #43793 (for 1.15).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure. labels Jan 20, 2021
@oiooj

This comment has been minimized.

@bcmills
Copy link
Contributor

bcmills commented Jan 20, 2021

Note that a robust fix should probably use internal/testenv.MustHaveExec and/or internal/testenv.MustHaveExecPath, not a hard-coded runtime.GOOS or runtime.GOARCH value.

@gopherbot
Copy link

Change https://golang.org/cl/284952 mentions this issue: internal/execabs: only run tests on platforms that support them

@oiooj

This comment has been minimized.

@dmitshur
Copy link
Contributor

This problem does not exist at tip now, the js-wasm builder is passing at https://build.golang.org. It will be introduced in CL 284783 if that CL is submitted as is. I agree with @ianlancetaylor's suggestion that we should just squash CL 284952 (which fixes this issue) into CL 284783 and avoid introducing this known problem into the tree. (This issue was useful for creating backports, since the problem did exist on release branches.)

I'll close this issue since it is currently resolved. (If needed, it can be reopened.)

@golang golang locked and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

5 participants