Skip to content

x/pkgsite: entire directories section highlighted when clicking on anchor #43773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
julieqiu opened this issue Jan 19, 2021 · 2 comments
Closed

x/pkgsite: entire directories section highlighted when clicking on anchor #43773

julieqiu opened this issue Jan 19, 2021 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Milestone
pkgsite/frontend

Comments

@julieqiu
Copy link
Member

What is the URL of the page with the issue?

http://localhost:8080/gocloud.dev#section-directories

(This change hasn't been deployed yet)

Screenshot

Screen Shot 2021-01-19 at 9 23 39 AM

What did you do?

Click on the "Directories" section in the left nav.

What did you expect to see?

Nothing

What did you see instead?

Entire directories section highlighted
@julieqiu julieqiu added NeedsFix The path to resolution is known, but the work has not been done. pkgsite labels Jan 19, 2021
@julieqiu julieqiu added this to the pkgsite/frontend milestone Jan 19, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/284572 mentions this issue: content/static/css: hide highlight CSS on anchors

gopherbot pushed a commit to golang/pkgsite that referenced this issue Jan 19, 2021
@julieqiu
content/static/css: hide highlight CSS on anchors
6de9ee3 
When visiting a #section-directories anchor tag, the entire section will
turn yellow.

This CSS is commented out for today's deploy.

For golang/go#43773

Change-Id: Ic9c26845203c6518a368ea19af36c42a21958354
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/284572
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
@jamalc jamalc self-assigned this Jan 28, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/287635 mentions this issue: content/static: re-enable target highlighting

@golang golang locked and limited conversation to collaborators Jan 28, 2022
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
@rsc rsc unassigned jamalc Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
4 participants
@hyangah @julieqiu @gopherbot @jamalc