Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wiki: CodeReviewComments change #43770

Closed
bunyk opened this issue Jan 19, 2021 · 1 comment
Closed

wiki: CodeReviewComments change #43770

bunyk opened this issue Jan 19, 2021 · 1 comment
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bunyk
Copy link
Contributor

bunyk commented Jan 19, 2021 •
edited

Imports section shows example:

import (
	"fmt"
	"hash/adler32"
	"os"

	"appengine/foo"
	"appengine/user"

	"github.com/foo/bar"
	"rsc.io/goversion/version"
)

From which it is not obvious that appengine is third-party package, not stdlib. And this is legacy way to import appengine: https://github.com/golang/appengine#updating-from-legacy-import-appengine-packages

I think this group should be removed from example, or updated.
@dmitshur dmitshur added Documentation NeedsFix The path to resolution is known, but the work has not been done. labels Jan 19, 2021
@dmitshur dmitshur added this to the Unreleased milestone Jan 19, 2021
@seankhliao
Copy link
Member

I've removed the group.

@golang golang locked and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bunyk @dmitshur @gopherbot @seankhliao