Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub mirror: lock conversations on GitHub commits #43745

Closed
ianlancetaylor opened this issue Jan 16, 2021 · 2 comments
Closed

GitHub mirror: lock conversations on GitHub commits #43745

ianlancetaylor opened this issue Jan 16, 2021 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@ianlancetaylor
Copy link
Contributor

The Go project mirrors all commits from Gerrit to GitHub. The GitHub commits point back to the associated Gerrit code review. Despite that, people sometimes comment on the GitHub commits. Very few people see those comments, and they don't help the overall project.

I don't know what does this mirroring, but is it possible for that process to lock the conversation for the GitHub commit? There is a "Lock conversation" link on the commit, so it seems that it ought to be possible to automate the locking process.

CC @golang/release
@ianlancetaylor ianlancetaylor added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 16, 2021
@ianlancetaylor ianlancetaylor added this to the Backlog milestone Jan 16, 2021
@dmitshur
Copy link
Contributor

dmitshur commented Jan 16, 2021 •
edited

The mirroring is done by gitmirror. Unfortunately, we are still waiting on GitHub to expose the ability to lock conversations on commits via an API (it's possible to lock issues and PRs, but not commits), see #25450 (comment). I just checked again, I don't think there's been a change on GitHub's side yet, although I know they have an internal tracking issue for it (CC @WillAbides). I'll close this as duplicate of #25450.

@ianlancetaylor
Copy link
Contributor Author

Thanks.

@golang golang locked and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@dmitshur @ianlancetaylor @gopherbot