Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: enable -rpc.trace logging to a file by default #43738

Open
stamblerre opened this issue Jan 16, 2021 · 1 comment
Open

x/tools/gopls: enable -rpc.trace logging to a file by default #43738

stamblerre opened this issue Jan 16, 2021 · 1 comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
gopls on-deck
Milestone
gopls/backlog

Comments

@stamblerre
Copy link
Contributor

This has been discussed frequently, but I don't believe there is an issue tracking the fix. We should enable logging by default, to a file, so that users can have an easier time sharing logs with us (and don't lose them if they restart their editors). Care needs to be taken that we don't fill up temp directories with large files.

/cc @heschik @findleyr @hyangah
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Jan 16, 2021
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 16, 2021
@hyangah
Copy link
Contributor

hyangah commented Jan 20, 2021

My original motivation was not the difficulty of capturing the trace, but the difficulty of sharing the contents.
Currently, one of the common causes of many issues is that the users' workspace settings are not in the state supported by gopls well (e.g. multiple modules, etc) and the info is often at the beginning of the trace. Unfortunately, I often find users simply capture logs without the beginning of the trace, or destroy too much information during their ad-hoc anonymization.

@stamblerre stamblerre added this to To Do in gopls on-deck Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
No open projects
gopls on-deck
To Do
Milestone
gopls/backlog
Development

No branches or pull requests
3 participants
@hyangah @stamblerre @gopherbot