Skip to content

syscall: make new RtlGenRandom API internal and safe #43704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aclements opened this issue Jan 14, 2021 · 2 comments
Closed

syscall: make new RtlGenRandom API internal and safe #43704

aclements opened this issue Jan 14, 2021 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.16

Comments

@aclements
Copy link
Member

During the Go 1.16 API audit, @rsc and I noticed that the new Windows syscall.RtlGenRandom API is 1. needlessly unsafe, and 2. should be added to internal/syscall/windows instead because syscall is frozen.

This is release-blocker issue to track this.

/cc @zx2c4 @alexbrainman
@aclements aclements added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Jan 14, 2021
@aclements aclements added this to the Go1.16 milestone Jan 14, 2021
@zx2c4
Copy link
Contributor

zx2c4 commented Jan 14, 2021

I'll fix it.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/283992 mentions this issue: syscall: remove RtlGenRandom and move it into internal/syscall

@golang golang locked and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
4 participants
@zx2c4 @aclements @gopherbot and others