Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/internal/task/releaselet: upgrading Go on windows should prompt with previous installation path #43681

Open
toothrot opened this issue Jan 13, 2021 · 4 comments
Open

x/build/internal/task/releaselet: upgrading Go on windows should prompt with previous installation path #43681

toothrot opened this issue Jan 13, 2021 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

What version of Go are you using (go version)?

Go 1.16beta1

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

windows-amd64 or windows-386

What did you do?

Installed Go to a custom path via the msi files on https://golang.org/dl. Installed a newer version of Go after that.

What did you expect to see?

I expected the installer to pre-populate my previous installation path in the path field when installing a new version.

What did you see instead?

The default path to install Go populated in the path field in the installation wizard.

Based on @lkarsund's comment here: #42070 (comment)
@toothrot toothrot added the Builders x/build issues (builders, bots, dashboards) label Jan 13, 2021
@toothrot toothrot added this to the Unreleased milestone Jan 13, 2021
@toothrot toothrot mentioned this issue Jan 13, 2021
Closed
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 14, 2021
@cagedmantis
Copy link
Contributor

/cc @golang/release

@nvx
Copy link

nvx commented Feb 17, 2021

I just ran into this on Go1.16 release with the Windows amd64 msi installer. Previous versions were installed at C:\Go\ and previous installers defaulted to that location, while the Go1.16 installer unexpectedly defaulted to installing to C:\Program Files\Go\

@cagedmantis
Copy link
Contributor

@nvx the rationale for that change can be found in issue #42070

@dmitshur dmitshur mentioned this issue Feb 23, 2023
Closed
@dmitshur dmitshur changed the title x/build/cmd/release: upgrading Go on windows should prompt with previous installation path x/build/internal/task/releaselet: upgrading Go on windows should prompt with previous installation path Feb 23, 2023
@gopherbot
Copy link

Change https://go.dev/cl/288252 mentions this issue: cmd/release: remember INSTALLDIR on upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@toothrot @cagedmantis @nvx @dmitshur @gopherbot and others