Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: TestCallbackInAnotherThread timeout on windows-arm-zx2c4 #43668

Open
bcmills opened this issue Jan 13, 2021 · 1 comment
Open

runtime: TestCallbackInAnotherThread timeout on windows-arm-zx2c4 #43668

bcmills opened this issue Jan 13, 2021 · 1 comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 13, 2021

2021-01-08T16:28:15-32afcc9/windows-arm-zx2c4

--- FAIL: TestCallbackInAnotherThread (0.10s)
    syscall_windows_test.go:272: timeout waiting for thread to exit
FAIL
FAIL	runtime	78.795s

The test hard-codes a 100ms timeout on the call:

go/src/runtime/syscall_windows_test.go

Line 268 in f1980ef

switch s, err := syscall.WaitForSingleObject(h, 100); s {

It's not clear to me whether the hard-coded timeout is correct — 100ms seems like a long time, but is it possible for the builder to naturally stall for that long, say, loading the CreateThread function from the DLL?

CC @alexbrainman @zx2c4 @bradfitz
@bcmills bcmills added OS-Windows NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 13, 2021
@bcmills bcmills added this to the Backlog milestone Jan 13, 2021
@bcmills bcmills mentioned this issue Feb 12, 2021
Open
@timmyyuan
Copy link

I also encountered this issue when I building go1.17.4 on Windows amd64:

##### GOMAXPROCS=2 runtime -cpu=1,2,4 -quick
--- FAIL: TestCallbackInAnotherThread (0.22s)
    syscall_windows_test.go:273: timeout waiting for thread to exit
FAIL
FAIL    runtime 101.437s
FAIL
2021/12/07 10:37:35 Failed: exit status 1

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Projects
Go Compiler / Runtime
Status: Triage Backlog
Milestone
Backlog
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @timmyyuan