Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: find implementations does not work on "error" types #43655

Closed
stamblerre opened this issue Jan 12, 2021 · 2 comments
Closed

x/tools/gopls: find implementations does not work on "error" types #43655

stamblerre opened this issue Jan 12, 2021 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
gopls on-deck
Milestone
gopls/v0.14.0

Comments

@stamblerre
Copy link
Contributor

Originally reported on fatih/vim-go#3135. error is a special case, so likely needs special handling.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 12, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jan 12, 2021
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Jan 12, 2021
@stamblerre stamblerre mentioned this issue Jan 12, 2021
Closed
@stamblerre stamblerre added this to To Do in gopls on-deck Feb 28, 2021
@ansaba ansaba added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 10, 2022
@findleyr
Copy link
Contributor

Note that simply adding type E = error and finding implementations of E works. This should therefore be easy to fix...

@findleyr findleyr modified the milestones: gopls/later, gopls/v0.13.2 Aug 1, 2023
@gopherbot
Copy link

Change https://go.dev/cl/518896 mentions this issue: gopls/internal/lsp/source: fix implementations query on error type

@findleyr findleyr modified the milestones: gopls/v0.13.2, gopls/v0.14.0 Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
No open projects
gopls on-deck
To Do
Milestone
gopls/v0.14.0
Development

No branches or pull requests
4 participants
@ansaba @stamblerre @gopherbot @findleyr