Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: don't invalidate metadata on didOpen of go.mod #43647

Closed
findleyr opened this issue Jan 12, 2021 · 1 comment
Closed

x/tools/gopls: don't invalidate metadata on didOpen of go.mod #43647

findleyr opened this issue Jan 12, 2021 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
gopls on-deck

Comments

@findleyr
Copy link
Contributor

This is an extension of #42529, where the solution to reload thrashing while editing the go.mod file was to only invalidate metadata on saves of the go.mod file.

Unfortunately, our invalidation logic treats didOpen notifications nearly identically to saves, as go.mod is in the "changed" set and saved == true. This can cause problems in testing, and I also suspect could be disruptive in some large workspaces where metadata reloading takes many seconds. It's also just counter-intuitive.

Related to #43554.

Not a high priority.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 12, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jan 12, 2021
@findleyr findleyr modified the milestones: Unreleased, gopls/v1.0.0 Jan 12, 2021
@stamblerre stamblerre added this to To Do in gopls on-deck Feb 28, 2021
@stamblerre
Copy link
Contributor

This has been fixed as of https://golang.org/cl/317450.

gopls on-deck automation moved this from To Do to Done Jun 28, 2021
@stamblerre stamblerre removed this from the gopls/v1.0.0 milestone Jun 28, 2021
@golang golang locked and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
No open projects
gopls on-deck
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @findleyr