Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestPacketConn failures with "i/o timeout" #43627

Closed
bcmills opened this issue Jan 11, 2021 · 3 comments
Closed

net: TestPacketConn failures with "i/o timeout" #43627

bcmills opened this issue Jan 11, 2021 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 11, 2021 •
edited 

darwin-amd64-nocgo at c515852732a490bab64f35d001ddc444b0f0f553

…
--- FAIL: TestPacketConn (40.39s)
    packetconn_test.go:79: write unixgram /var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/go-nettest742938503->/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/tmp/go-nettest590542138: i/o timeout
FAIL
FAIL	net	64.287s

2021-01-08T15:41:36-c6513bc/linux-riscv64-jsing
2020-10-27T19:52:40-c515852/darwin-amd64-nocgo
2020-10-25T05:19:20-7930d39/linux-riscv64-jsing
2020-10-20T02:32:44-9ad090c/linux-riscv64-jsing
2020-09-17T12:37:40-967465d/openbsd-arm-jsing
2020-07-09T20:19:47-574dac9/openbsd-arm-jsing
2020-07-07T16:14:42-18d042e/openbsd-arm-jsing
2020-07-03T03:31:29-dd15017/openbsd-arm-jsing
2020-07-01T09:07:18-84152d5/openbsd-arm-jsing
2020-06-30T20:14:48-96e8366/openbsd-arm-jsing
2020-06-25T02:59:06-d7e3a16/openbsd-arm-jsing
2020-06-23T00:10:24-968e18e/openbsd-arm-jsing
2020-06-19T02:11:35-3dec253/openbsd-arm-jsing
2020-06-17T05:23:15-340efd3/openbsd-arm-jsing
2020-06-15T19:05:29-15e3e0d/openbsd-arm-jsing
2020-06-11T14:40:28-f7ba82d/openbsd-arm-jsing
2020-06-10T01:31:35-b9332ed/openbsd-arm-jsing
2020-06-05T19:17:58-d282b0f/openbsd-arm-jsing
2020-06-04T10:53:46-b371f18/openbsd-arm-jsing
2020-05-31T02:07:28-f1f8f9a/openbsd-arm-jsing
2020-05-31T00:55:05-8da7862/openbsd-arm-jsing
2020-05-29T20:55:14-c2d1df6/openbsd-arm-jsing
2020-05-29T09:21:54-1519bc4/openbsd-arm-jsing
2020-05-26T22:28:45-b2ce393/openbsd-arm-jsing
2020-05-20T19:21:43-daf70d6/openbsd-arm-jsing
2020-05-15T16:15:25-2b70ffe/openbsd-arm-jsing
2020-05-13T18:00:00-b819adf/openbsd-arm-jsing
2020-05-12T19:15:34-cb11c98/openbsd-arm-jsing
2020-05-10T14:43:46-57e32c4/openbsd-arm-jsing
2020-05-09T04:46:25-0242d46/openbsd-arm-jsing
2020-05-08T20:44:01-7cbee12/openbsd-arm-jsing
2020-05-08T20:28:57-26de581/openbsd-arm-jsing
2020-05-08T20:24:33-8f4be42/openbsd-arm-jsing
2020-05-08T13:29:11-b1a48af/openbsd-arm-jsing
2020-05-08T02:00:35-43f2f50/openbsd-arm-jsing
2020-05-08T00:05:04-9d1e120/openbsd-arm-jsing
2020-05-07T14:29:38-cb14bd8/openbsd-arm-jsing
2020-05-06T01:27:05-fdb8a3e/openbsd-arm-jsing
2020-05-03T07:23:32-53f2747/openbsd-arm-jsing
2020-05-01T06:37:35-fffe622/openbsd-arm-jsing
2020-05-01T05:30:49-b8fd3ca/openbsd-arm-jsing
2020-04-29T11:57:50-07d9ea6/openbsd-arm-jsing
2020-04-27T11:55:27-bce1e25/openbsd-arm-jsing
2020-04-24T22:01:49-d8d3542/darwin-amd64-race
2020-04-24T08:21:27-82f2989/openbsd-arm-jsing
2020-04-16T17:52:53-8c00e07/openbsd-arm-jsing

See previously #5524. It's not clear to me whether this is a symptom of a real bug in the net package, an unreasonably short hard-coded timeout in the test, or something else.

CC @bradfitz @ianlancetaylor @4a6f656c
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 11, 2021
@bcmills bcmills added this to the Backlog milestone Jan 11, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Dec 1, 2021

greplogs --dashboard -md -l -e 'FAIL: TestPacketConn ' --since=2021-01-12

2021-12-01T06:03:27-a412b5f/linux-riscv64-jsing
2021-11-24T20:54:07-6ea17aa/linux-riscv64-jsing
2021-11-05T05:30:39-b68c02e/linux-riscv64-jsing
2021-10-22T21:48:34-ae4d67c/linux-riscv64-jsing
2021-09-28T23:59:17-435718e/linux-riscv64-jsing
2021-09-28T20:40:48-daec057/linux-riscv64-jsing
2021-09-24T19:40:03-cfd0868/linux-riscv64-jsing
2021-08-25T03:07:54-41b99da/netbsd-arm-bsiegert
2021-08-21T00:24:02-c991278/openbsd-arm64-jsing
2021-07-26T17:47:47-ecaa681/linux-riscv64-jsing
2021-07-02T20:11:05-287c5e8/linux-riscv64-jsing
2021-05-30T17:47:50-3b770f2/linux-riscv64-jsing
2021-05-08T17:03:18-b38b1b2/linux-riscv64-jsing
2021-04-30T05:18:37-9c72078/linux-riscv64-jsing
2021-04-28T20:36:50-fa6ed6e/linux-riscv64-jsing
2021-04-23T01:16:19-cfac62a/linux-riscv64-jsing
2021-04-09T00:11:25-d25c4fb/linux-riscv64-jsing
2021-03-25T08:43:17-402d784/linux-riscv64-jsing
2021-03-19T01:38:59-9136d95/linux-riscv64-jsing

@gopherbot
Copy link

Change https://golang.org/cl/368215 mentions this issue: net: remove arbitrary deadlines in PacketConn tests

gopherbot pushed a commit that referenced this issue Dec 2, 2021
net: remove arbitrary deadlines in PacketConn tests
1b2930d 
When TestPacketConn was added (in CL 6501057) it included arbitrary
100ms deadlines. Those deadlines were arbitrarily increased to 500ms
in CL 4922.

If the test is actually provoking a deadlock, allowing it to deadlock
will give us a more useful goroutine dump. Otherwise, the deadlines
don't seem all that useful — they appear to increase code coverage,
but have no effect on the test in the typical case, and can only
cause flakes on particularly-slow machines.

For #43627

Change-Id: I83de5217c54c743b83adddf51d4f6f2bd5b91732
Reviewed-on: https://go-review.googlesource.com/c/go/+/368215
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@bcmills
Copy link
Contributor Author

bcmills commented Dec 3, 2021

Fixed by CL 368215.

@bcmills bcmills closed this as completed Dec 3, 2021
@bcmills bcmills self-assigned this Dec 3, 2021
@bcmills bcmills modified the milestones: Backlog, Go1.18 Dec 3, 2021
@rsc rsc unassigned bcmills Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
2 participants
@bcmills @gopherbot