Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/ecdsa: change hashToBytes to use copy instead of calling another function #43532

Closed
pschou opened this issue Jan 6, 2021 · 2 comments
Closed

crypto/ecdsa: change hashToBytes to use copy instead of calling another function #43532

pschou opened this issue Jan 6, 2021 · 2 comments
Labels
FrozenDueToAge

Comments

@pschou
Copy link

pschou commented Jan 6, 2021 •
edited

Just reducing a double function call to a byte copy. A TODO request. ;)

Pull request
#43531

Pull request discussion is here:
https://go-review.googlesource.com/c/go/+/281832
@gopherbot gopherbot added this to the Proposal milestone Jan 6, 2021
@mvdan mvdan changed the title proposal: crypto/ecdsa: change hashToBytes to use copy instead of calling another function #43531 crypto/ecdsa: change hashToBytes to use copy instead of calling another function Jan 6, 2021
@mvdan mvdan removed the Proposal label Jan 6, 2021
@mvdan mvdan removed this from the Proposal milestone Jan 6, 2021
@mvdan
Copy link
Member

mvdan commented Jan 6, 2021

This does not need to be a proposal. You wouldn't even need an issue really, since it's just an internal change that already had a TODO.

Also CC @mundaym.

@pschou
Copy link
Author

pschou commented Jan 6, 2021 •
edited

Oh-- oops! Thanks for the heads up here. I didn't realize this. Feel free to do what you need to do. :P

@golang golang locked and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ianlancetaylor @mvdan @gopherbot @pschou