Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/talks: modernize concurrency.slide onto avoid serving back “unexpected EOF” #43455

Closed
Aju100 opened this issue Jan 1, 2021 · 9 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Unfortunate
Milestone

Comments

@Aju100
Copy link

Aju100 commented Jan 1, 2021

Hi opensource contributors,

After learning from the Go Heroku's Waza conference entitled Concurrency is not parallelism. I decided to go its slide but the slide link was broken up.
concurrency
links

I hope a lot of developers went through the video and learned it. But there might be a developer who prefers slides too for learning purposes. Having a proper link with its content can solve this issue.

Link of the site: Golang official blog

@ALTree
Copy link
Member

ALTree commented Jan 1, 2021

Thanks for reporting this. It looks like it's not the link that is broken, but the rendering of presentation itself. If you go here: https://talks.golang.org/2012, these three:

  • concurrency.slide
  • tutorial.slide
  • waza.slide

are all broken.

cc @dmitshur

@odeke-em odeke-em changed the title [Request] Missing slide of concurrency slide x/talks: modernize concurrency.slide onto avoid serving back “unexpected EOF” Jan 1, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jan 1, 2021
@odeke-em
Copy link
Member

odeke-em commented Jan 1, 2021

Hello @Aju100, welcome to the Go project! Happy New Year, and thank you for identifying this problem!

I believe that the problem is that the slides might not use the godoc format, and might be outdated, so perhaps we should modernize them. @robpike, it would be an honor for you to perhaps take a look at concurrency.slide which you created for that iconic talk, otherwise I can take a look and mail the fixes. Also cheers @dmitshur!
Thank you.

EDIT: I hadn’t seen @ALTree’s analysis (perhaps typed concurrently) but yes, what @ALTree said (thanks and Happy New Year @ALTree)

@Aju100
Copy link
Author

Aju100 commented Jan 1, 2021

@odeke-em @ALTree thank you and Happy New year.

@robpike
Copy link
Contributor

robpike commented Jan 2, 2021

I believe @rsc has a tool for this.

@toothrot toothrot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 5, 2021
@kortschak
Copy link
Contributor

kortschak commented Jan 15, 2021

There is a command for this, present2md, but there are a couple of problems with it; the parsing of caption commands is broken in some conditions and comments are not retained. These will result in incomplete translation of tutorial.slide and waza.slide. There is also a problem for dot commands without a previous blank line which won't affect any of the decks listed above.

All of these are addressed in existing CLs:

@gopherbot
Copy link

Change https://golang.org/cl/284392 mentions this issue: content/2012: prevent present from misinterpretting comment as title

@kortschak
Copy link
Contributor

@robpike Does this talks server need to be bumped? It is still serving text that is broken, and with titles that come from text that was removed; both of concurrency.slide and tutorial.slide are titled "This is a file." on the 2012 directory view but these lines were removed.

@dmitshur
Copy link
Contributor

dmitshur commented Jan 21, 2021

@kortschak That is expected, the talks server needs to be redeployed. There's some work that needs to be done. We'll look into doing it possibly next week. (Edit: This is done by now.)

@robpike
Copy link
Contributor

robpike commented Jan 21, 2021

"Expected," no. "Unfortunate," yes. The deployment process has rotted, it seems, and needs to be repaired. It will take a few days.

@dmitshur dmitshur added Unfortunate NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 21, 2021
@golang golang locked and limited conversation to collaborators Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Unfortunate
Projects
None yet
Development

No branches or pull requests

8 participants