Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/analysis/passes/fieldalignment: add a command? #43446

Closed
ainar-g opened this issue Dec 31, 2020 · 1 comment
Closed

x/tools/go/analysis/passes/fieldalignment: add a command? #43446

ainar-g opened this issue Dec 31, 2020 · 1 comment
Labels
FrozenDueToAge help wanted Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Dec 31, 2020

The recently-added fieldalignment analyser is very useful, but it seems like it's currently only available as a part of gopls. If there are no plans to integrate it into go vet, perhaps it should have an accompanying command, like shadow and nilness do.
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Dec 31, 2020
@gopherbot gopherbot added this to the Unreleased milestone Dec 31, 2020
@gopherbot
Copy link

Change https://golang.org/cl/280617 mentions this issue: go/analysis/passes/fieldalignment: add command

gopherbot pushed a commit to golang/tools that referenced this issue Jan 11, 2021
@leitzler @dmitshur
go/analysis/passes/fieldalignment: add command
c4dccaf 
Add fieldalignment as a singlechecker.

Closes golang/go#43446

Change-Id: Ibc3bcc45087d56d429c66a74758b17bda01e7ef3
Reviewed-on: https://go-review.googlesource.com/c/tools/+/280617
Trust: Pontus Leitzler <leitzler@gmail.com>
Run-TryBot: Pontus Leitzler <leitzler@gmail.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
@golang golang locked and limited conversation to collaborators Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@ainar-g @stamblerre @gopherbot