Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mobile/cmd/gomobile: gomobile build on simple program returns "ld: error: duplicate symbol: x_cgo_inittls" [1.15 backport] #43406

Closed
gopherbot opened this issue Dec 28, 2020 · 3 comments
Closed

x/mobile/cmd/gomobile: gomobile build on simple program returns "ld: error: duplicate symbol: x_cgo_inittls" [1.15 backport] #43406

gopherbot opened this issue Dec 28, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge mobile Android, iOS, and x/mobile
Milestone
Go1.15.8

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #42655 to be considered for backport to the next 1.15 minor release.

@gopherbot Please open backport issues

Although this was filed against x/mobile, the fix is to runtime/cgo in the standard library. This is caused by a change in the default behavior of the C compiler. Anybody using an older release of Go with a new C compiler will run into this problem. Since the fix is small and safe, we should backport it.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Dec 28, 2020
@gopherbot gopherbot mentioned this issue Dec 28, 2020
Closed
@gopherbot gopherbot added the mobile Android, iOS, and x/mobile label Dec 28, 2020
@gopherbot gopherbot modified the milestones: Unreleased, Go1.15.7 Dec 28, 2020
@dmitshur
Copy link
Contributor

The rationale sounds good. Approving (for 1.15 and 1.14 both).

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Dec 30, 2020
@jbpratt jbpratt mentioned this issue Dec 31, 2020
Closed
@dmitshur dmitshur modified the milestones: Go1.15.7, Go1.15.8 Jan 19, 2021
@Jorropo Jorropo mentioned this issue Jan 20, 2021
Closed
@gopherbot
Copy link
Author

Change https://golang.org/cl/289149 mentions this issue: [release-branch.go1.15] runtime/cgo: fix Android build with NDK 22

@cagedmantis cagedmantis mentioned this issue Feb 4, 2021
Closed
@gopherbot
Copy link
Author

Closed by merging c3e1c38 to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Feb 4, 2021
@eliasnaur @cagedmantis
[release-branch.go1.15] runtime/cgo: fix Android build with NDK 22
c3e1c38 
Fixes #43406

Change-Id: I7d2b70098a4ba4dcb325fb0be076043789b86135
Reviewed-on: https://go-review.googlesource.com/c/go/+/280312
Run-TryBot: Elias Naur <mail@eliasnaur.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Elias Naur <mail@eliasnaur.com>
(cherry picked from commit 1d78139)
Reviewed-on: https://go-review.googlesource.com/c/go/+/289149
@golang golang locked and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge mobile Android, iOS, and x/mobile
Projects
None yet
Milestone
Go1.15.8
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot