Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: enable -mod=readonly in workspace module mode #43346

Closed
findleyr opened this issue Dec 23, 2020 · 1 comment
Closed

x/tools/gopls: enable -mod=readonly in workspace module mode #43346

findleyr opened this issue Dec 23, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.6.5

Comments

@findleyr
Copy link
Contributor

When using multi-project gopls workspaces, invoking the go command with -mod=readonly fails because the go command wants to modify the synthetic versions we use in the workspace module's go.mod file.

We should tidy as part of constructing the workspace module.

CC @stamblerre @heschik
@findleyr findleyr added this to the gopls/v1.0.0 milestone Dec 23, 2020
@findleyr findleyr self-assigned this Dec 23, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 23, 2020
@gopherbot
Copy link

Change https://golang.org/cl/287032 mentions this issue: internal/lsp: enable -mod=readonly in workspace module mode

@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.6.5 Feb 1, 2021
@golang golang locked and limited conversation to collaborators Feb 1, 2022
@rsc rsc unassigned heschi and findleyr Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.6.5
Development

No branches or pull requests
4 participants
@stamblerre @gopherbot @heschi @findleyr