-
Notifications
You must be signed in to change notification settings - Fork 18k
x/build/cmd/coordinator: failing to complete TryBot run for change with duplicate Change-Id line #43324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@aclements pointed out that Gerrit won't let one upload new patch sets to such a Gerrit CL. That probably means it's not very useful to make coordinator work well it, since it's easy to just close and resend as a new CL with a unique Change-Id line. I'll remove the "Run-TryBot" vote on CL 279514 and close as WontFix, since this issue is isolated to a single problematic Gerrit CL. If we get evidence that it's important to support this edge case, or if this becomes needed during investigation for #43323, we can revisit. |
I believe I found a similar instance of this: https://farmer.golang.org/try?commit=48b8a530 which is for golang.org/cl/301589.
The commit message is:
While this seems like it was user initiated, I wanted to make sure it was documented somewhere. I'm going to comment out the wrong Change-ID and restart the trybot run. |
Visible at https://farmer.golang.org/#trybots right now:
Note that it has 0 builds remaining, yet it's not completing.
This is related to #43312 and #43323, but about the specific instance above.
It is likely to do with the
build~master~Ib1c7ae1e914116dd8a4440db8ee46d6af3ed1ad5
triplet being non-unique, so perhaps it's failing to post the TryBot result. Now that the more time-sensitive #43312 is resolved, it should be easier to look in logs to understand this part better.CC @aclements.
The text was updated successfully, but these errors were encountered: