Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/pprof: provide memory mapping info on Windows #43296

Closed
egonelbre opened this issue Dec 20, 2020 · 2 comments
Closed

runtime/pprof: provide memory mapping info on Windows #43296

egonelbre opened this issue Dec 20, 2020 · 2 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Milestone
Backlog

Comments

@egonelbre
Copy link
Contributor

Noticed during google/pprof#592.

Currently Windows is missing memory mapping info similarly to Mac (#19790). This doesn't work very well in conjunction with ASLR. This results in addresses that do not match the binary. The workaround is to use -buildmode exe to disable it.

Windows does seem to have VirtualQueryEx to get the necessary information. (https://reverseengineering.stackexchange.com/a/8299). Minimally it would be nice to get the mapping for the main executable.
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 22, 2020
@cagedmantis cagedmantis added this to the Backlog milestone Dec 22, 2020
@cagedmantis
Copy link
Contributor

/cc @hyangah

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
@gopherbot
Copy link

Change https://go.dev/cl/416975 mentions this issue: runtime/pprof: add memory mapping info for Windows

@golang golang locked and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@cagedmantis @egonelbre @gopherbot