Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/build: TestDependencies is broken #43249

Closed
FiloSottile opened this issue Dec 17, 2020 · 2 comments
Closed

go/build: TestDependencies is broken #43249

FiloSottile opened this issue Dec 17, 2020 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.16

Comments

@FiloSottile
Copy link
Contributor

findImports is invoking readGoInfo without info.fset, which apparently is now required to extract imports, so findImports always returns an empty slice. The result is that TestDependencies always passes, and is not actually checking that packages respect the policy.

Marking release-blocker because we might have drifted and grown dependency edges that we don't want.

(Not fixing it because I am supposed to be OOO today.)

/cc @rsc @golang/release
@FiloSottile FiloSottile added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Dec 17, 2020
@FiloSottile FiloSottile added this to the Go1.16 milestone Dec 17, 2020
@ianlancetaylor ianlancetaylor self-assigned this Dec 17, 2020
@gopherbot
Copy link

Change https://golang.org/cl/279072 mentions this issue: os: remove dependency on strings package

@gopherbot
Copy link

Change https://golang.org/cl/279073 mentions this issue: go/build: make TestDependencies work again

gopherbot pushed a commit that referenced this issue Dec 18, 2020
@ianlancetaylor
os: remove dependency on strings package
2de7866 
Historically the os package has not imported the strings package.
That was enforced by go/build.TestDependencies, but that test
was accidentally broken (#43249). A dependency of os on strings
was accidentally added by CL 266364; remove it.

For #42026
For #43249

Change-Id: If932308f30561fdcc5c608d7563e849c0d2870d8
Reviewed-on: https://go-review.googlesource.com/c/go/+/279072
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
@golang golang locked and limited conversation to collaborators Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
4 participants
@FiloSottile @ianlancetaylor @gopherbot and others