I'm trying my hand at this, but it seems like implementing the API that I've proposed could be tricky, since .../source.UserOptions.Analyzers is currently a map[string]bool, and changing the type of the values there from a bool to some kind of sum-type-thru-interface-type could introduce a lot of changes. If there is an existing mechanism of configuring options for analysers, I couldn't find it.

So, I could add two boolean options, "shadow":true and "shadowstrict":true, and make the latter override the former. Or, I could add an "analyzerFlags" setting:

{
  // …
, "analyzerFlags": {
  // …
  , "shadow": ["--strict"]
  }
}

Or, there may be an option (heh) I don't see.

How should I proceed?

I think the path that fits best with LSP would be a map[string]interface{} where each value is the set of options for the given analyzer. However, I think the current strategy of passing flags to the analyzer will be not be compatible with our analysis runner, so there may need to be some new API for passing options to analyzers (cc @matloob).

As a starting point, could we add the shadow analyzer as off-by-default and with strict turned off?

Change https://golang.org/cl/279395 mentions this issue: internal/lsp/source: add the shadow analyzer

@stamblerre, done.

Probably unrelated, but while working on the change I've found this go:generate directive which doesn't work on my machine:

//go:generate go run golang.org/x/tools/internal/lsp/source/genapijson -output api_json.go

The error I got was:

$ go generate ./internal/lsp/source/
go: finding module for package golang.org/x/tools/internal/lsp/source/genapijson
no matching versions for query "latest"
internal/lsp/source/options.go:67: running "go": exit status 1

Thanks for reporting that--I believe it's outdated. /cc @heschik