Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: 'run file benchmarks' codelens for files without benchmark functions #43239

Closed
hyangah opened this issue Dec 17, 2020 · 1 comment
Closed

x/tools/gopls: 'run file benchmarks' codelens for files without benchmark functions #43239

hyangah opened this issue Dec 17, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.6.2

Comments

@hyangah
Copy link
Contributor

hyangah commented Dec 17, 2020

When enabled the test codelens ("gopls": { "codelenses": { "test": true } }), gopls was sending run file benchmarks codelens for files that don't contain any benchmarks.
Clicking the codelens leads to failure.
Screen Shot 2020-12-16 at 11 36 21 PM
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 17, 2020
@gopherbot gopherbot added this to the Unreleased milestone Dec 17, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.6.1 Dec 17, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/278780 mentions this issue: internal/lsp/source: only show "run file benchmarks" if available

@golang golang locked and limited conversation to collaborators Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.6.2
Development

No branches or pull requests
3 participants
@hyangah @stamblerre @gopherbot