Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/exp/shiny/driver/gldriver: fails to build on darwin/arm64 because its gl dependency doesn't support darwin/arm64 yet #43237

Closed
dmitshur opened this issue Dec 17, 2020 · 2 comments
Closed

x/exp/shiny/driver/gldriver: fails to build on darwin/arm64 because its gl dependency doesn't support darwin/arm64 yet #43237

dmitshur opened this issue Dec 17, 2020 · 2 comments
Labels
arch-arm64 FrozenDueToAge mobile Android, iOS, and x/mobile NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

2020-12-15T15:35:30-b5a6e24/darwin-arm64-11_0-toothrot

# golang.org/x/mobile/gl
In file included from /tmp/buildlet/gopath/pkg/mod/golang.org/x/mobile@v0.0.0-20190719004257-d2bd2a29d028/gl/work.go:29:
./work.h:18:10: fatal error: 'OpenGLES/ES2/glext.h' file not found
#include <OpenGLES/ES2/glext.h>
         ^~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Similar to #43221, but for OpenGL.

Support for darwin/arm64 needs to be added to golang.org/x/mobile/gl, then x/exp needs to pull in the new version.
@dmitshur dmitshur added OS-Darwin NeedsFix The path to resolution is known, but the work has not been done. mobile Android, iOS, and x/mobile arch-arm64 labels Dec 17, 2020
@dmitshur dmitshur added this to the Backlog milestone Dec 17, 2020
@dmitshur dmitshur self-assigned this Dec 17, 2020
@dmitshur dmitshur modified the milestones: Backlog, Unreleased Dec 17, 2020
@gopherbot
Copy link

Change https://golang.org/cl/278779 mentions this issue: gl: add darwin/arm64 (macOS) support

@gopherbot
Copy link

Change https://golang.org/cl/278761 mentions this issue: shiny/driver/gldriver: add darwin/arm64 (macOS) support

gopherbot pushed a commit to golang/mobile that referenced this issue Dec 17, 2020
@dmitshur
gl: add darwin/arm64 (macOS) support
e6ae53a 
Update the build constraints so that OpenGL is used both on
macOS AMD64 and ARM64, while OpenGL ES is used on iOS.
This fixes the build on M1 Macs.

For golang/go#43237.

Change-Id: Iad2d406eaf0ddbe72f221f497dd074ad0b22015e
Reviewed-on: https://go-review.googlesource.com/c/mobile/+/278779
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@gmail.com>
@dmitshur dmitshur mentioned this issue Feb 6, 2021
Closed
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 10, 2021
@dmitshur
gl: add darwin/arm64 (macOS) support
c3dfe0b 
Update the build constraints so that OpenGL is used both on
macOS AMD64 and ARM64, while OpenGL ES is used on iOS.
This fixes the build on M1 Macs.

For golang/go#43237.

Change-Id: Iad2d406eaf0ddbe72f221f497dd074ad0b22015e
Reviewed-on: https://go-review.googlesource.com/c/mobile/+/278779
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@gmail.com>
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 11, 2021
@dmitshur
gl: add darwin/arm64 (macOS) support
274a36d 
Update the build constraints so that OpenGL is used both on
macOS AMD64 and ARM64, while OpenGL ES is used on iOS.
This fixes the build on M1 Macs.

For golang/go#43237.

Change-Id: Iad2d406eaf0ddbe72f221f497dd074ad0b22015e
Reviewed-on: https://go-review.googlesource.com/c/mobile/+/278779
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@gmail.com>
@oubiwann oubiwann mentioned this issue Nov 28, 2021
Closed
@golang golang locked and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-arm64 FrozenDueToAge mobile Android, iOS, and x/mobile NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot