Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: makes http requests to random websites while editing module directive #43187

Closed
josharian opened this issue Dec 14, 2020 · 2 comments
Closed

x/tools/gopls: makes http requests to random websites while editing module directive #43187

josharian opened this issue Dec 14, 2020 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.

Comments

@josharian
Copy link
Contributor

In an attempt to make a small reproducer for #43186, I created a go.mod that started:

module vanilla.xyz

After saving, I selected the word vanilla and started typing "chocolate" as a replacement. As I typed, gopls started attempting to retrieve results from intermediate domains choco.xyz, chocola.xyz, chocolat.xyz, despite me not hitting save. Sample alert from Little Snitch:

Screen Shot 2020-12-14 at 2 36 33 PM

The partial module import path seemed to get cached, because well after I finished typing an hit save, I still got this error:

Screen Shot 2020-12-14 at 2 37 22 PM
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 14, 2020
@gopherbot gopherbot added this to the Unreleased milestone Dec 14, 2020
@stamblerre
Copy link
Contributor

gopls currently tries to reload package metadata as you modify import statements in your file, which is why you saw these requests. We have made some changes in recent weeks to default to GOPROXY=off--can you try the latest gopls pre-release and confirm that it fixes the issue? You can download it by running GO111MODULE=on go get golang.org/x/tools/gopls@v0.6.0-pre.1.

@stamblerre stamblerre added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Dec 15, 2020
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default via automation Dec 16, 2020
@stamblerre stamblerre moved this from Needs Triage to Waiting for Info in vscode-go: gopls by default Dec 16, 2020
@stamblerre stamblerre moved this from Waiting for Info to Non-critical in vscode-go: gopls by default Jan 8, 2021
@stamblerre stamblerre moved this from Non-critical to Needs Triage in vscode-go: gopls by default Jan 8, 2021
@stamblerre stamblerre removed this from Needs Decision in vscode-go: gopls by default Jan 8, 2021
@stamblerre stamblerre modified the milestones: gopls/v0.6.3, gopls/v1.0.0 Jan 14, 2021
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@stamblerre stamblerre removed this from the gopls/v1.0.0 milestone Jan 15, 2021
@golang golang locked and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@josharian @stamblerre @gopherbot