Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: support Windows resource files on windows/arm [freeze exception] #43182

Closed
aclements opened this issue Dec 14, 2020 · 4 comments
Closed

cmd/link: support Windows resource files on windows/arm [freeze exception] #43182

aclements opened this issue Dec 14, 2020 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.16

Comments

@aclements
Copy link
Member

aclements commented Dec 14, 2020 •
edited

This is a formal freeze exception request for #42866 (which was maybe itself a freeze exception request, but that's not clear at the top).

In Go 1.16, windows/arm support is being revived. However, because of differences in platform tooling used to build Windows resource files, the Go linker is not currently compatible with resource files on windows/arm. Since it's common for Windows Go binaries to link against Windows resource files, it's not currently possible to build many complete Go applications on windows/arm.

@zx2c4 would like to land a series of fairly small changes to the Go linker (summarized here) to support Windows resource files produced by platform tools on windows/arm. We'd like to do this in 1.16 to coincide with the revival of windows/arm support.

cc @golang/release
@aclements aclements added this to the Go1.16 milestone Dec 14, 2020
@aclements aclements mentioned this issue Dec 14, 2020
Closed
@dmitshur
Copy link
Contributor

Thank you for making this freeze exception request. We've considered it on the release team and are okay with it.

Approved.

Is your plan to land those changes in time for the beta 1? This issue currently blocks beta 1 (because there isn't an okay-after-beta1 label).

@zx2c4
Copy link
Contributor

zx2c4 commented Dec 14, 2020

The changes are ready now, as far as I can tell, so as soon as the +2s arrive, I'll submit them.

@aclements
Copy link
Member Author

We're doing final reviews of @zx2c4 's CLs now. I don't think this has to block beta 1, though.

@aclements aclements added the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Dec 14, 2020
@gopherbot
Copy link

Change https://golang.org/cl/268337 mentions this issue: cmd/link: handle grouped resource sections

@toothrot toothrot added NeedsFix The path to resolution is known, but the work has not been done. and removed okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 labels Dec 17, 2020
@golang golang locked and limited conversation to collaborators Dec 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
5 participants
@toothrot @zx2c4 @dmitshur @aclements @gopherbot