New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: failure to diagnose re-declaring dot-imported identifiers #43167
Comments
this dot-imported identifiers diagnose , and this seem to not elegance for use dot imported. |
@KeKe-Li Sorry, I don't follow. The Go spec defines how import declarations should behave: https://golang.org/ref/spec#Import_declarations. go/types and gccgo are correctly implementing that for the linked program. cmd/compile is not. |
@mdempsky seems that we don't check for re-declared when processing |
@cuonglm I think we weren't setting I have fixes for a bunch of these dot-import issues. Just polishing up the CLs to get ready for upload. |
Ah right, seems that |
Change https://golang.org/cl/277713 mentions this issue: |
This CL substantially reworks how imported declarations are handled, and fixes a number of issues with dot imports. In particular: 1. It eliminates the stub ir.Name declarations that are created upfront during import-declaration processing, allowing this to be deferred to when the declarations are actually needed. (Eventually, this can be deferred even further so we never have to create ir.Names w/ ONONAME, but this CL is already invasive/subtle enough.) 2. During noding, we now use ir.Idents to represent uses of imported declarations, including of dot-imported declarations. 3. Unused dot imports are now reported after type checking, so that we can correctly distinguish whether composite literal keys are a simple identifier (struct literals) or expressions (array/slice/map literals) and whether it might be a use of a dot-imported declaration. 4. It changes the "redeclared" error messages to report the previous position information in the same style as other compiler error messages that reference other source lines. Passes buildall w/ toolstash -cmp. Fixes #6428. Fixes #43164. Fixes #43167. Updates #42990. Change-Id: I40a0a780ec40daf5700fbc3cfeeb7300e1055981 Reviewed-on: https://go-review.googlesource.com/c/go/+/277713 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org> Trust: Matthew Dempsky <mdempsky@google.com>
Fixed on dev.regabi. |
This program should fail to compile with an error that Index was already declared due to dot-importing package bytes: https://play.golang.org/p/EAPSJQRfm2F
go/types and gccgo correctly diagnose this; cmd/compile does not.
The text was updated successfully, but these errors were encountered: