Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/doc: don't synthesize runnable examples for examples that won't run #4309

Closed
bradfitz opened this issue Oct 29, 2012 · 6 comments
Closed

go/doc: don't synthesize runnable examples for examples that won't run #4309

bradfitz opened this issue Oct 29, 2012 · 6 comments
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Go1.1

Comments

@bradfitz
Copy link
Contributor 

http://golang.org/pkg/text/template/#example_Template_glob

> prog.go:14: undefined: createTestDir
> prog.go:14: undefined: templateFile

Rob: "the examples run in go test just fine, so i suspect they're not being
extracted properly."
@robpike
Copy link
Contributor

robpike commented Oct 30, 2012

Comment 1:

Labels changed: added priority-soon.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Dec 10, 2012

Comment 4:

Labels changed: added size-m.

@rsc
Copy link
Contributor

rsc commented Dec 10, 2012

Comment 5:

Labels changed: added suggested.

@adg
Copy link
Contributor

adg commented Dec 19, 2012

Comment 6:

Status changed to Started.

@adg
Copy link
Contributor

adg commented Dec 19, 2012

Comment 7:

Sent CL: https://golang.org/cl/6974045/

@adg
Copy link
Contributor

adg commented Dec 20, 2012

Comment 8:

This issue was closed by revision ff27cdb.

Status changed to Fixed.

@bradfitz bradfitz added fixed Suggested Issues that may be good for new contributors looking for work to do. labels Dec 20, 2012
@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
@rsc rsc unassigned adg Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Go1.1
Development

No branches or pull requests
5 participants
@bradfitz @rsc @robpike @adg @gopherbot