runtime/metrics: TestDescriptionDocs fails when GOROOT_FINAL is non-empty #43085
Labels
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
Testing
An issue that has been verified to require only test changes, not just a test failure.
Milestone
At tip-ish:
The
TestDescriptionDocs
test passes whenGOROOT_FINAL
is empty (vast majority of the time):But fails when non-empty:
This is only a problem if it's important for
runtime/metrics
tests to be able to pass whenGOROOT_FINAL
is set. @mknyszek Is that an environment configuration you'd like to support?If so, I suspect fixing the test can be done by simplifying:
To just
os.Open("doc.go")
, becausego test
always sets the working directory to that of the package, so there's no need to do more.This currently affects release testing (similarly to #39385, #39478, #39386 in the past), but we can easily work around it on our side by no longer setting
GOROOT_FINAL
during release testing. (I think that's likely what we'll do independent of this issue, but it's a separate discussion. I think we may also want a builder whereGOROOT_FINAL
is set to help catch such test failures.)CC @bcmills, @golang/release.
The text was updated successfully, but these errors were encountered: