Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: border around examples after click #43053

Closed
prattmic opened this issue Dec 7, 2020 · 3 comments
Closed

x/pkgsite: border around examples after click #43053

prattmic opened this issue Dec 7, 2020 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Milestone
pkgsite/frontend

Comments

@prattmic
Copy link
Member

prattmic commented Dec 7, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/strings#TrimLeft (any page with examples)

What is your user agent?

Mozilla/5.0 (X11; CrOS x86_64 13421.102.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.199 Safari/537.36

Screenshot

Screenshot 2020-12-07 at 12 20 30

What did you do?

  1. Click "Example" to expand the example.
  2. Click anywhere in the expanded view (the word "Code:", in the code/output box, or even the whitespace above the code box.)

What did you expect to see?

Click (2) does nothing.

What did you see instead?

Click (2) adds a black border around the example. Perhaps this is intentional? But it seems superfluous to me.
@gopherbot gopherbot added this to the Unreleased milestone Dec 7, 2020
@prattmic
Copy link
Member Author

prattmic commented Dec 7, 2020

Ooo, this one is fun: https://pkg.go.dev/golang.org/x/net/ipv4#example-PacketConn-ServingOneShotMulticastDNS. The border around this example extends up through some of the text above the example:

Screenshot 2020-12-07 at 12 29 43

@jamalc jamalc modified the milestones: Unreleased, pkgsite/frontend Dec 7, 2020
@jamalc
Copy link

jamalc commented Dec 7, 2020

Related to #42698

@jamalc jamalc added NeedsFix The path to resolution is known, but the work has not been done. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed NeedsFix The path to resolution is known, but the work has not been done. labels Dec 8, 2020
@julieqiu
Copy link
Member

Closing as a dupe of #42698.

@golang golang locked and limited conversation to collaborators Dec 21, 2021
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
5 participants
@prattmic @hyangah @julieqiu @gopherbot @jamalc