Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile/internal/types2: wrong line numbers in errors for constant overflows involving iota #42992

Closed
griesemer opened this issue Dec 4, 2020 · 2 comments
Closed

cmd/compile/internal/types2: wrong line numbers in errors for constant overflows involving iota #42992

griesemer opened this issue Dec 4, 2020 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.17

Comments

@griesemer
Copy link
Contributor

This is the same as #42991 for go/types but for types2.
@griesemer griesemer added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 4, 2020
@griesemer griesemer added this to the Go1.17 milestone Dec 4, 2020
@griesemer griesemer self-assigned this Dec 4, 2020
@gopherbot
Copy link

Change https://golang.org/cl/275517 mentions this issue: [dev.typeparams] cmd/compile/internal/types2: correct error position for inherited const init expression

gopherbot pushed a commit that referenced this issue Dec 7, 2020
@griesemer
[dev.typeparams] cmd/compile/internal/types2: correct error position …
cd15a48 
…for inherited const init expression

Enabled fixedbugs/issue8183.go for run.go with new typechecker
now that issue is fixed.

Fixes #42992.
Updates #42991.

Change-Id: I23451999983b740d5f37ce3fa75ee756daf1a44f
Reviewed-on: https://go-review.googlesource.com/c/go/+/275517
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
@griesemer
Copy link
Contributor Author

This was fixed with https://golang.org/cl/275517.

@golang golang locked and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
2 participants
@griesemer @gopherbot