Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: linux/riscv64 is missing from valid combinations list #42978

Closed
jfcg opened this issue Dec 3, 2020 · 2 comments
Closed

x/website: linux/riscv64 is missing from valid combinations list #42978

jfcg opened this issue Dec 3, 2020 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@jfcg
Copy link

jfcg commented Dec 3, 2020

Doc site misses linux,riscv64 combo under GOOS,GOARCH combo list.
However go 1.15.5 can build with this combo and riscv64 is listed as a supported instruction set in introduction.
@ALTree
Copy link
Member

ALTree commented Dec 3, 2020 •
edited

Looks like the doc page in the main repo was updated here: https://go-review.googlesource.com/c/go/+/250997

But no corresponding CL was sent to the website repository:
https://github.com/golang/website/blob/c8f27351e764fa8954631d243dd24779108bd026/content/static/doc/install-source.html#L530

@ALTree ALTree added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 3, 2020
@ALTree ALTree changed the title doc/install/source: GOOS,GOARCH=linux,riscv64 is missing x/website: linux/riscv64 is missing from valid combinations list Dec 3, 2020
@gopherbot gopherbot added this to the Unreleased milestone Dec 3, 2020
@gopherbot
Copy link

Change https://golang.org/cl/275495 mentions this issue: content/static/doc: list linux/riscv64 as a valid combination

@golang golang locked and limited conversation to collaborators Dec 7, 2021
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
content/static/doc: list linux/riscv64 as a valid combination
c9cee22 
This change applies CL 250997 to the x/website repository.

Fixes golang/go#42978

Change-Id: I10bbd97d40c5defe26b892c68a38555ee2fa8781
Reviewed-on: https://go-review.googlesource.com/c/website/+/275495
Trust: Alberto Donizetti <alb.donizetti@gmail.com>
Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@jfcg @ALTree @gopherbot