-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: enable builder-specific GOPROXY settings on reverse builders #42971
Comments
Please assign this issue to me. @bcmills |
To other builders maintainer, linux-amd64-wsl using systemd to set the enviroment.
|
@mengzhuo Take a look at https://golang.org/wiki/GitHubAccess#assignees. |
Change https://golang.org/cl/275332 mentions this issue: |
Change https://golang.org/cl/275412 mentions this issue: |
If anything else need to be change, I'd like to push it. |
@golang/release: this is a frequent failure mode on multiple reverse builders, and there has been a fix CL (CL 275412) out for review since December 2020. Can we prioritize a review for that change at some point in the near future? |
Builders behind firewall may not access to proxy.golang.org but has its own private Go module proxy linux-mips64le-mengzhuo linux-amd64-wsl linux-riscv64-unmatched NeedsGoProxy is for long test used which we should not change. Update golang/go#42971 Change-Id: If300b751487ae08e05f5200581eb4c2719706a56 Reviewed-on: https://go-review.googlesource.com/c/build/+/275412 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Lee Baokun <bk@golangcn.org> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
CL 275412 has now landed. Comparing a recent before/after log shows it's working as intended: there's no more unwanted We can check again in a few weeks to make sure the same problem doesn't happen again for another reason, but at least so far there aren't any new hits (other than one yesterday, before the fix):
|
Unfortunately, https://build.golang.org/log/58e02729ea56983be383b850ca96f268ba258e4b:
|
cc @oiooj as goproxy.io maintainer |
I tested this request and there is no problem so far.
and goproxy.io use Tencent Cloud global CDN service. 😢 |
|
At any rate: it looks like the builder-specific I'll file a separate issue for the connection errors on the builders using |
(Filed the |
Looking at the builder log in https://build.golang.org/log/26ea2fd1426a51a224b5d321915717e906ded84a, I see the following line. Note that it lists
GOPROXY
three different times andGOROOT_BOOTSTRAP
twice::: Running /tmp/farm/go/bin/go with args ["/tmp/farm/go/bin/go" "test" "-short" "golang.org/x/crypto/..."] and env ["LANG=zh_CN.UTF-8" "PATH=/tmp/farm/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOME=/home/gopher" "LOGNAME=gopher" "USER=gopher" "SHELL=/bin/bash" "INVOCATION_ID=fe969678216d4cceaebbdc436df708c2" "JOURNAL_STREAM=8:4142335" "GO_BUILDER_ENV=host-linux-amd64-wsl" "WORKDIR=/tmp/farm" "HTTPS_PROXY=http://proxy:8123" "HTTP_PROXY=http://proxy:8123" "GOPROXY=https://goproxy.io,direct" "WSL_DISTRO_NAME=Ubuntu" "WSL_INTEROP=/run/WSL/20_interop" "WSLENV=BASH_ENV/u" "GO_STAGE0_NET_DELAY=700ms" "GO_STAGE0_DL_DELAY=600ms" "GOROOT_BOOTSTRAP=/tmp/farm/go1.4" "GO_BUILDER_NAME=linux-amd64-wsl" "GO_BUILDER_FLAKY_NET=1" "GOROOT_BOOTSTRAP=/usr/lib/go" "GOROOT=/tmp/farm/go" "GOPATH=/tmp/farm/gopath" "GOPROXY=http://10.240.0.3:30157" "GOPROXY=https://proxy.golang.org" "TMPDIR=/tmp/farm/tmp" "GOCACHE=/tmp/farm/gocache"] in dir /tmp/farm/gopath/src/golang.org/x/crypto
The second
GOROOT_BOOTSTRAP
seems to come from here, and might be working as intended: https://github.com/golang/build/blob/a9f75ee9992b28221ceec0c56af51265ea857ce2/cmd/buildlet/buildlet.go#L263The second
GOPROXY
setting comes from here: https://github.com/golang/build/blob/5f1e306b98a112c236997d393adc5c11405377ca/cmd/coordinator/coordinator.go#L2702The third
GOPROXY
setting comes from here: https://github.com/golang/build/blob/b6220de1adc000cad31eadf59558e1d3a8e32205/dashboard/builders.go#L921-L925Given that one of the tests in that log failed with an
EOF
error communicating withproxy.golang.org
, I suspect that it really should be using the localGOPROXY
default (https://goproxy.io,direct
) instead of thecmd/go
default. I'm not sure what needs to happen to fix that configuration.CC @mengzhuo @cagedmantis @golang/release
The text was updated successfully, but these errors were encountered: