Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflect: update StructTag documentation to describe multiple space-separated keys #42959

Closed
dmitshur opened this issue Dec 2, 2020 · 3 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Dec 2, 2020

Proposal #40281 was accepted and implemented for Go 1.16 in CL 248341. It seems the public documentation of reflect.StructTag was not updated as part of the implementation. It still says:

Each key is a non-empty string consisting of non-control characters other than space (U+0020 ' '), quote (U+0022 '"'), and colon (U+003A ':').

That is no longer accurate/complete. It needs to be updated to describe the new behavior.

CC @bynov, @deven96, @rsc, @ianlancetaylor.

@dmitshur dmitshur added Documentation release-blocker okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 labels Dec 2, 2020
@dmitshur dmitshur added this to the Go1.16 milestone Dec 2, 2020
@gopherbot
Copy link

Change https://golang.org/cl/274448 mentions this issue: reflect: document multiple keys in struct tags

@myitcv
Copy link
Member

myitcv commented Dec 3, 2020

Just noting that this particular change managed to fly under the radar of a number of folk in the golang-tools group. Seemingly we all missed #40281. I wonder if there's a way in which we can ensure that group is looped in for changes that might require changes in Go tools?

For example https://twitter.com/fatih/status/1334058605704691712

@ianlancetaylor
Copy link
Contributor

Yes, absolutely. Although I have to admit that it would not have occurred to me that any tools needed updating for this change. Now that you point it out it's obvious, but I didn't think of it myself.

@cagedmantis cagedmantis added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 4, 2020
@golang golang locked and limited conversation to collaborators Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker
Projects
None yet
Development

No branches or pull requests

5 participants