Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: remove ID dedup code #42956

Closed
jba opened this issue Dec 2, 2020 · 1 comment
Closed

x/pkgsite: remove ID dedup code #42956

jba opened this issue Dec 2, 2020 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Milestone
pkgsite/frontend

Comments

@jba
Copy link
Contributor

jba commented Dec 2, 2020

collectJumpListItemsFallback in content/static/js/jump.js has code to dedup IDs, but there should no longer be duplicate IDs, so the code can be removed.
@jba jba added NeedsFix The path to resolution is known, but the work has not been done. pkgsite labels Dec 2, 2020
@jba jba added this to the pkgsite/unplanned milestone Dec 2, 2020
@gopherbot
Copy link

Change https://golang.org/cl/274954 mentions this issue: content/static/js: remove collectJumpListItemsFallback

@golang golang locked and limited conversation to collaborators Dec 3, 2021
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
@rsc rsc unassigned jamalc Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
5 participants
@hyangah @julieqiu @gopherbot @jamalc @jba