Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/parser: ParseDir shouldn't assume anything with .go suffix is a file #42951

Closed
griesemer opened this issue Dec 2, 2020 · 2 comments
Closed

go/parser: ParseDir shouldn't assume anything with .go suffix is a file #42951

griesemer opened this issue Dec 2, 2020 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.16

Comments

@griesemer
Copy link
Contributor

This is goreleaser/goreleaser#1897 .

There's a pending CL: https://golang.org/cl/269897.
@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 2, 2020
@griesemer griesemer added this to the Go1.17 milestone Dec 2, 2020
@caarlos0 caarlos0 mentioned this issue Dec 2, 2020
Closed
@gopherbot
Copy link

Change https://golang.org/cl/269897 mentions this issue: go/parser: ParseDir shouldn't assume anything with .go suffix is a file

@griesemer
Copy link
Contributor Author

The fix is trivial, so if the Go release maintainers are ok with it, I'm fine to add it to 1.16.

@griesemer griesemer modified the milestones: Go1.17, Go1.16 Dec 2, 2020
@golang golang locked and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.16
Development

Successfully merging a pull request may close this issue.

go/parser: ignore subdirectories in ParseDir
3 participants
@griesemer @gopherbot @findleyr