Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: unexpected bindingNone in '_go.buildid' [1.15 backport] #42948

Closed
gopherbot opened this issue Dec 2, 2020 · 4 comments
Closed

cmd/link: unexpected bindingNone in '_go.buildid' [1.15 backport] #42948

gopherbot opened this issue Dec 2, 2020 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.15.6

Comments

@gopherbot
Copy link

@robbertvanginkel requested issue #42082 to be considered for backport to the next 1.15 minor release.

@gopherbot please consider this for backport to 1.15, it's a linker regression that prevents some programs from linking succesfully.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Dec 2, 2020
@gopherbot gopherbot mentioned this issue Dec 2, 2020
Closed
@gopherbot gopherbot added this to the Go1.15.6 milestone Dec 2, 2020
@robbertvanginkel
Copy link

According to #42082 (comment) https://golang.org/cl/270942 is open against the 1.15 release branch to resolve this. I've cherry-picked onto 1.15.5 locally and validated it solves our issue.

This is about a regression introduced in 1.15 that prevents us from linking some binaries for darwin. There are no workarounds.

@gopherbot
Copy link
Author

Change https://golang.org/cl/270942 mentions this issue: [release-branch.go1.15] cmd/link: recompute heapPos after copyHeap

@cagedmantis
Copy link
Contributor

This has been approved as it is a serious issue without a known workaround.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Dec 2, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Dec 2, 2020
@gopherbot
Copy link
Author

Closed by merging 480da60 to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Dec 3, 2020
@cherrymui @cagedmantis
[release-branch.go1.15] cmd/link: recompute heapPos after copyHeap
480da60 
Immediately after a forward Seek, the offset we're writing to is
beyond len(buf)+len(heap):

|<--- buf --->|<--- heap --->|
                                    ^
                                    off

If we do a copyHeap at this point, the new heapPos should not be
0:

|<---------- buf ----------->|<-heap->|
                                    ^
                                    off

Recompute it.

Updates #42082
Fixes #42948

Change-Id: Icb3e4e1c7bf7d1fd3d76a2e0d7dfcb319c661534
Reviewed-on: https://go-review.googlesource.com/c/go/+/270942
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
Trust: Cherry Zhang <cherryyz@google.com>
@golang golang locked and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.15.6
Development

No branches or pull requests
3 participants
@cagedmantis @robbertvanginkel @gopherbot