Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/perf: build failures due to C compiler warnings in github.com/mattn/go-sqlite3 #42941

Closed
bcmills opened this issue Dec 2, 2020 · 4 comments
Closed

x/perf: build failures due to C compiler warnings in github.com/mattn/go-sqlite3 #42941

bcmills opened this issue Dec 2, 2020 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 2, 2020

2020-09-18T15:55:09-d949658/solaris-amd64-oraclerel

# github.com/mattn/go-sqlite3
sqlite3-binding.c: In function ‘sqlite3SelectNew.isra’:
sqlite3-binding.c:114528:10: warning: function may return address of local variable [-Wreturn-local-addr]
114528 |   return pNew;
       |          ^~~~
sqlite3-binding.c:114488:10: note: declared here
114488 |   Select standin;
       |          ^~~~~~~
go build github.com/mattn/go-sqlite3: C compiler warning promoted to error on Go builders

2020-09-18T15:55:09-d949658/openbsd-386-68
2020-09-18T15:55:09-d949658/openbsd-amd64-68

# github.com/mattn/go-sqlite3
sqlite3-binding.c:104476:38: warning: implicit conversion from 'long long' to 'double' changes value from 9223372036854775806 to 9223372036854775808 [-Wimplicit-int-float-conversion]
sqlite3-binding.c:104478:46: warning: implicit conversion from 'long long' to 'double' changes value from 9223372036854775806 to 9223372036854775808 [-Wimplicit-int-float-conversion]
go build github.com/mattn/go-sqlite3: C compiler warning promoted to error on Go builders

CC @golang/release via #11811
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 2, 2020
@gopherbot gopherbot added this to the Unreleased milestone Dec 2, 2020
@bcmills
Copy link
Contributor Author

bcmills commented Dec 2, 2020

These failures appear to have started as of CL 222540, which suggests that those builders were previously using the vendor directory, although I'm not sure how. (The default -mod=vendor trigger is go 1.14 or higher in the go.mod file, but the go.mod file for this module is only go 1.11.)

@bcmills
Copy link
Contributor Author

bcmills commented Dec 2, 2020

The implicit conversion seems to be mattn/go-sqlite3#867, which AFAICT is fixed upstream at head.

@bcmills
Copy link
Contributor Author

bcmills commented Dec 2, 2020

The function may return address of local variable warning seems to be mattn/go-sqlite3#803 / mattn/go-sqlite3#822.

@bcmills
Copy link
Contributor Author

bcmills commented Dec 4, 2020

Fixed by CL 275192.

@bcmills bcmills closed this as completed Dec 4, 2020
@bcmills bcmills self-assigned this Dec 4, 2020
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 7, 2020
@golang golang locked and limited conversation to collaborators Dec 7, 2021
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot