all: cleanup ineffectual //go:linkname directives #42938
Labels
FrozenDueToAge
help wanted
NeedsFix
The path to resolution is known, but the work has not been done.
Suggested
Issues that may be good for new contributors looking for work to do.
Milestone
Comments
mdempsky
added
the
NeedsFix
|
Change https://golang.org/cl/274732 mentions this issue: |
mdempsky
added
help wanted
Suggested
gopherbot
pushed a commit
that referenced
this issue
Dec 2, 2020
It's noisy and not doing any harm, and we still have an entire release cycle to revisit and address the issue properly. Updates #42938 Change-Id: I1de5cfb495a8148c9c08b215deba38f2617fb467 Reviewed-on: https://go-review.googlesource.com/c/go/+/274732 Trust: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
|
Change https://golang.org/cl/274573 mentions this issue: |
gopherbot
pushed a commit
to golang/sys
that referenced
this issue
Dec 2, 2020
For golang/go#42938 Change-Id: I9d68a2436f3ce7402b3c6517a630d0272cf39071 Reviewed-on: https://go-review.googlesource.com/c/sys/+/274573 Trust: Tobias Klauser <tobias.klauser@gmail.com> Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
|
Is there more to do here? Are we going to do anything further for the 1.17 release? |
|
We're three weeks into the release freeze now. It seems this is either mostly done, or if there's more to do, progress can be continued in a future Go release, so I'll move it to Backlog. @mdempsky Please feel free to update the issue as needed. |
|
@mdempsky seems we can close this issue now? |
|
ping |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There are a lot of //go:linkname directives in macOS packages that don't do anything. We should remove them.
To elaborate, a directive like
//go:linkname foo barsets the Go variable or function namedfooto usebaras its linker symbol (instead ofmypkgpath.foo, like it would normally use). But if there's no Go variable or function namedfoo, it just silently doesn't do anything.In CL 273986 (2d6ff99), I removed the occurrences within the standard library, but there are more in the vendored x/sys package that need to be fixed. There might be more instances in other repos too.
To test for problems, you can checkout the
dev.regabibranch; revert CL 274732 (42e46f4); and then build packages like golang.org/x/sys/unix w/ various GOOS/GOARCH combinations.The text was updated successfully, but these errors were encountered: