Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review/git-codereview: test timed out on windows-arm-zx2c4 builder #42925

Closed
bcmills opened this issue Dec 1, 2020 · 10 comments
Closed

x/review/git-codereview: test timed out on windows-arm-zx2c4 builder #42925

bcmills opened this issue Dec 1, 2020 · 10 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 1, 2020

2020-09-11T20:38:40-0edcede/windows-arm-zx2c4

Not obvious to me whether the builder is just slow or the test triggered some kind of deadlock.

CC @zx2c4 @golang/release
@bcmills bcmills added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 1, 2020
@gopherbot gopherbot added this to the Unreleased milestone Dec 1, 2020
@zx2c4
Copy link
Contributor

zx2c4 commented Dec 1, 2020

It might just be slow. If this test is doing a lot of disk IO, that can really slow things down.

@bcmills
Copy link
Contributor Author

bcmills commented Dec 1, 2020 •
edited

It's testing the git-codereview Git hooks, so it probably does a moderate amount of I/O, but it's not exactly a long, intensive test — 10 minutes seems like it should be more than adequate.

That said, I can't seem to run the test locally to get a baseline for how long it should take (#42926).

@zx2c4
Copy link
Contributor

zx2c4 commented Dec 1, 2020

If it's doing a lot of git operations, this hits a triple whammy of slow: NTFS small file performance is pretty bad, the I/O on this box is pretty slow, and git itself is compiled only for x86 not arm, so it runs in Windows' rosetta2 situation.

@bcmills
Copy link
Contributor Author

bcmills commented Dec 1, 2020

In that case, would it make sense to configure the builder to skip the x/review repo, or perhaps to use a larger timeout scale factor?

@zx2c4
Copy link
Contributor

zx2c4 commented Dec 1, 2020

I think that's at least worth a try, yes. For starters, the timeout scale factor. I'm not quite sure how to go about doing that in the x/build repo, if you want to take a stab at it. Alternatively, if there's some env var I should set on the builder, I can do that.

@dmitshur
Copy link
Contributor

dmitshur commented Dec 1, 2020

The GO_TEST_TIMEOUT_SCALE variable can be used to scale timeout, but it applies to the entire builder, not a specific repository. It's defined here, and there are many examples of it used in dashboard/builders.go.

@zx2c4
Copy link
Contributor

zx2c4 commented Dec 1, 2020

Will send a CL.

@gopherbot
Copy link

Change https://golang.org/cl/274572 mentions this issue: dashboard: expand time scale for windows-arm builder

gopherbot pushed a commit to golang/build that referenced this issue Dec 1, 2020
@zx2c4
dashboard: expand time scale for windows-arm builder
b6220de 
This builder has very slow I/O and could benefit from some extra time on
a few tests. At the moment, the tests for x/review/git-codereview are
failing with a time out, for example.

Updates golang/go#42925.

Change-Id: I532f4ddd3b9e7fd0a66ea9631b3fa7ce363e05a4
Reviewed-on: https://go-review.googlesource.com/c/build/+/274572
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/275237 mentions this issue: cmd/relui: add datastore support

@bcmills bcmills mentioned this issue Feb 12, 2021
Open
@bcmills
Copy link
Contributor Author

bcmills commented Nov 11, 2021

This builder no longer exists, so the issue is obsolete.
(We may need to revisit this when a new windows-arm builder is added; see #47019.)

@bcmills bcmills closed this as completed Nov 11, 2021
@golang golang locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@zx2c4 @dmitshur @bcmills @gopherbot