Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/go1.16: document vet changes for Go 1.16 #42895

Closed
dmitshur opened this issue Nov 30, 2020 · 8 comments
Closed

doc/go1.16: document vet changes for Go 1.16 #42895

dmitshur opened this issue Nov 30, 2020 · 8 comments
Labels
Documentation FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone

Comments

@dmitshur
Copy link
Contributor

As of filing this issue, the Go 1.16 draft release notes contained the following HTML:

<h3 id="vet">Vet</h3>

<p>
  TODO

  <!-- CL 235677: https://golang.org/cl/235677: cmd/vet: bring in pass to catch invalid uses of testing.T in goroutines -->
</p>

Per golang.org/s/release, it's a release blocker for Go 1.16 Beta 1 to have a complete draft of the eventual release notes, and so the TODO needs to be resolved.

A sequence of steps to resolve this issue may be:

  1. Come up with a draft release note entry in this issue, then move the issue to NeedsFix state.
  2. Send a CL with "doc/go1.16:" prefix and include "For doc: write Go 1.16 release notes #40700. Fixes #{this issue}." in the body.
@dmitshur dmitshur added Documentation help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Nov 30, 2020
@dmitshur dmitshur added this to the Go1.16 milestone Nov 30, 2020
@dmitshur dmitshur assigned dmitshur and unassigned dmitshur Nov 30, 2020
@dmitshur
Copy link
Contributor Author

dmitshur commented Dec 1, 2020

@timothy-king has offered to take this. Thanks!

@gopherbot
Copy link

Change https://golang.org/cl/274617 mentions this issue: doc/go1.16: add vet release note for CL 235677

@randall77
Copy link
Contributor

We might also want to mention https://go-review.googlesource.com/c/tools/+/248686 (vet pass to check for invalid frame pointer usage).

@randall77
Copy link
Contributor

Actually, that change has not been vendored in from x/tools yet. Is that scheduled to happen at some point, or should I do that explicitly?

@dmitshur
Copy link
Contributor Author

dmitshur commented Dec 4, 2020

@randall77 I'm looking to pull in changes that are in scope for Go 1.16 in CL 275446 (which may end up being split into smaller commits, or otherwise changed not to pull everything in). That is to say, it should happen, but it's not guaranteed to. If it's important for it to be included in Go 1.16 beta 1, please file a separate issue for it and CC me on it. You can send a CL that updates just x/tools to resolve it.

Edit: I see that it'll need a change in cmd/vet to start using the new framepointer package, not just a newer x/tools version, so a separate issue is definitely needed.

@randall77
Copy link
Contributor

Ok, I'll open a new issue and prepare some CLs.

@timothy-king
Copy link
Contributor

@dmitshur Can you cc me if framepointer is added to the release?

@dmitshur
Copy link
Contributor Author

dmitshur commented Dec 8, 2020

@timothy-king Please see CL 276372 and CL 276373 that @randall77 just sent.

@golang golang locked and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Development

No branches or pull requests

4 participants