Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: deadlock on transaction stmt context cancel [1.14 backport] #42883

Closed
gopherbot opened this issue Nov 30, 2020 · 6 comments
Closed
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone

Comments

@gopherbot
Copy link

@pjm0616 requested issue #40985 to be considered for backport to the next 1.14 minor release.

@gopherbot @odeke-em Please consider this for backport to 1.15 and 1.14.
This regression, introduced in 1.14.6 and 1.15(by #34775), has a serious impact(deadlock) and no workarounds, other than patching Go manually.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Nov 30, 2020
@gopherbot gopherbot added this to the Go1.14.13 milestone Nov 30, 2020
@cagedmantis cagedmantis modified the milestones: Go1.14.13, Go1.14.14 Dec 3, 2020
@cagedmantis
Copy link
Contributor

Approved as this is a serious issue without a known workaround.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Jan 14, 2021
@cagedmantis
Copy link
Contributor

Please remember to create the cherry-pick CL.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jan 14, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/284512 mentions this issue: [release-branch.go1.14] database/sql: fix tx stmt deadlock when rollback

@odeke-em
Copy link
Member

Roger that, I've mailed a CL.

@dmitshur dmitshur modified the milestones: Go1.14.14, Go1.14.15 Jan 19, 2021
@cagedmantis
Copy link
Contributor

Would @kardianos be willing to review this since they approved the original CL?

@cagedmantis cagedmantis modified the milestones: Go1.14.15, Go1.14.16 Feb 4, 2021
@dmitshur
Copy link
Contributor

Closing because Go 1.16 is out, and there will not be a Go 1.14.16 minor release per release policy.

@golang golang locked and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

4 participants