Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows/arm: failure in TestDLLPreloadMitigation #42860

Closed
zx2c4 opened this issue Nov 27, 2020 · 1 comment
Closed

windows/arm: failure in TestDLLPreloadMitigation #42860

zx2c4 opened this issue Nov 27, 2020 · 1 comment
Labels
FrozenDueToAge

Comments

@zx2c4
Copy link
Contributor

zx2c4 commented Nov 27, 2020

Builder is currently failing with:

--- FAIL: TestDLLPreloadMitigation (1.40s)
    syscall_windows_test.go:986: failed to build dll: exit status 1 - nojack.c:7:1: error: non-void function does not return a value [-Werror,-Wreturn-type]
        }
        ^
        1 error generated.

This is because clang's warnings are stricter, I guess. Seems easy to add a return 0 to the end of:

uintptr_t cfunc() {
   SetLastError(123);
}

CC @alexbrainman @bcmills @aclements @cherrymui
@gopherbot
Copy link

Change https://golang.org/cl/273726 mentions this issue: runtime: return 0 from C function

@golang golang locked and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zx2c4 @gopherbot