Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: improve "have X want Y" error with additional file and line information #42841

Closed
raspi opened this issue Nov 26, 2020 · 5 comments
Closed

cmd/compile: improve "have X want Y" error with additional file and line information #42841

raspi opened this issue Nov 26, 2020 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.18

Comments

@raspi
Copy link

raspi commented Nov 26, 2020

What version of Go are you using (go version)?

go1.15.5 linux/amd64

Does this issue reproduce with the latest release?

Yes

What did you do?

package main

type S interface {
	DoSomething() (int, error)
}

type myS struct{}

func (s myS) DoSomething() (string, error) {
	return ``, nil
}

func main() {
	var _ S = &myS{}
}

What did you expect to see?

Show also line information (foo.go:123:57) for have line. The implementation might be in completely different file. In modern IDEs you simply can click the file information line to navigate to referenced file and line quickly.

want could also have line information to referenced interface definition line?

./prog.go:14:6: cannot use &myS literal (type *myS) as type S in assignment:
	*myS does not implement S (wrong type for DoSomething method)
		have DoSomething() (string, error) at ./prog.go:9:28
		want DoSomething() (int, error)

What did you see instead?

./prog.go:14:6: cannot use &myS literal (type *myS) as type S in assignment:
	*myS does not implement S (wrong type for DoSomething method)
		have DoSomething() (string, error)
		want DoSomething() (int, error)
@networkimprov
Copy link

cc @mdempsky @griesemer

Seems overlooked by triage?

@griesemer griesemer added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 7, 2020
@griesemer griesemer added this to the Go1.17 milestone Dec 7, 2020
@griesemer griesemer self-assigned this Dec 7, 2020
@mdempsky mdempsky changed the title Improve "have X want Y" error with additional file and line information cmd/compile: improve "have X want Y" error with additional file and line information Jan 18, 2021
@griesemer griesemer mentioned this issue Apr 28, 2021
Closed
@griesemer griesemer modified the milestones: Go1.17, Go1.18 Apr 28, 2021
@ianlancetaylor
Copy link
Contributor

@griesemer Should this stay in the Go1.18 milestone or should we move it to Backlog?

@griesemer
Copy link
Contributor

I think this is either done or mostly done (or pending CL). We should keep this for 1.18; I will take care of it.

@gopherbot
Copy link

Change https://golang.org/cl/373634 mentions this issue: cmd/compile/types2: add position failed failed interface satisfaction error

@odeke-em
Copy link
Member

I've mailed a CL for this per https://golang.org/cl/373634.

@odeke-em odeke-em self-assigned this Jan 6, 2022
jproberts pushed a commit to jproberts/go that referenced this issue Jun 21, 2022
@odeke-em @jproberts
cmd/compile/types2, go/types: add position for "have" in failed inter…
5fdbf03 
…face satisfaction

With this change, we shall now see:

    *myS does not implement S (wrong type for DoSomething method)
        have DoSomething() (string, error) at ./main.go:9:14
	want DoSomething() (int, error)

instead of previously:

    *myS does not implement S (wrong type for DoSomething method)
        have DoSomething() (string, error)
	want DoSomething() (int, error)

Fixes golang#42841
Fixes golang#45813

Change-Id: I66990929e39b0d36f2e91da0d92f60586a9b84e5
Reviewed-on: https://go-review.googlesource.com/c/go/+/373634
Trust: Robert Findley <rfindley@google.com>
Trust: Emmanuel Odeke <emmanuel@orijtech.com>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
6 participants
@raspi @networkimprov @ianlancetaylor @odeke-em @griesemer @gopherbot