x/tools/gopls: incorrectly tokenized import statements #42831
Labels
FrozenDueToAge
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
WaitingForInfo
Issue is not actionable because of missing required information, which needs to be provided.
Comments
gopherbot
added
Tools
stamblerre
added
the
NeedsFix
|
quite right. It is off by 1. Thank you.
…On Wed, Nov 25, 2020 at 11:53 AM Rebecca Stambler ***@***.***> wrote:
[image: Screen Shot 2020-11-25 at 11 50 37 AM]
<https://user-images.githubusercontent.com/5856771/100257965-827ccb00-2f14-11eb-80f0-7000e8016a04.png>
See the colors in this block:
import (
"fmt"
"os"
)
The entirety of "fmt" and the closing quote of "os" are tokenized as
strings, and "os is tokenized as a namespace. My guess is that there's
something off about the positions.
/cc @pjweinb <https://github.com/pjweinb>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42831>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJIAI7HCDSTUISDVY5JDM3SRUY75ANCNFSM4UCUYDDQ>
.
|
|
and embarrassing too. It's just like that in my golden test output, and I
never noticed.
…On Wed, Nov 25, 2020 at 1:31 PM Peter Weinberger ***@***.***> wrote:
quite right. It is off by 1. Thank you.
On Wed, Nov 25, 2020 at 11:53 AM Rebecca Stambler <
***@***.***> wrote:
> [image: Screen Shot 2020-11-25 at 11 50 37 AM]
> <https://user-images.githubusercontent.com/5856771/100257965-827ccb00-2f14-11eb-80f0-7000e8016a04.png>
>
> See the colors in this block:
>
> import (
> "fmt"
> "os"
> )
>
> The entirety of "fmt" and the closing quote of "os" are tokenized as
> strings, and "os is tokenized as a namespace. My guess is that there's
> something off about the positions.
>
> /cc @pjweinb <https://github.com/pjweinb>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#42831>, or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABJIAI7HCDSTUISDVY5JDM3SRUY75ANCNFSM4UCUYDDQ>
> .
>
|
|
My colors are different. How are you getting that?
package main
import (
"fmt"
"os"
)
func main() {
fmt.Println()
os.Exit(0)
}
…On Wed, Nov 25, 2020 at 1:37 PM Peter Weinberger ***@***.***> wrote:
and embarrassing too. It's just like that in my golden test output, and I
never noticed.
On Wed, Nov 25, 2020 at 1:31 PM Peter Weinberger ***@***.***> wrote:
> quite right. It is off by 1. Thank you.
>
> On Wed, Nov 25, 2020 at 11:53 AM Rebecca Stambler <
> ***@***.***> wrote:
>
>> [image: Screen Shot 2020-11-25 at 11 50 37 AM]
>> <https://user-images.githubusercontent.com/5856771/100257965-827ccb00-2f14-11eb-80f0-7000e8016a04.png>
>>
>> See the colors in this block:
>>
>> import (
>> "fmt"
>> "os"
>> )
>>
>> The entirety of "fmt" and the closing quote of "os" are tokenized as
>> strings, and "os is tokenized as a namespace. My guess is that there's
>> something off about the positions.
>>
>> /cc @pjweinb <https://github.com/pjweinb>
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <#42831>, or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/ABJIAI7HCDSTUISDVY5JDM3SRUY75ANCNFSM4UCUYDDQ>
>> .
>>
>
|
|
hmm, lost the colors. But in your block, I don't think semantic tokens is on. With semantic tokens, fmt and Println would have different types and different colors. (As would os and Exit) |
pjweinb
added
WaitingForInfo
|
I thought semantic tokens was on, but you're right, I can no longer reproduce. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
See the colors in this block:
The entirety of
"fmt"and the closing quote of"os"are tokenized as strings, and"osis tokenized as a namespace. My guess is that there's something off about the positions./cc @pjweinb
The text was updated successfully, but these errors were encountered: